ngraham created this revision.
ngraham added reviewers: VDG, ndavis, Frameworks, sitter.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.
REVISION SUMMARY
Right now we have 24px monochrome icons for compatibility with GTK apps,
which use icons
of this size. However they are visually identical to the 22px versions, with
one pixel of
padding on all sides. Manually creating them is tedious busywork.
This patch automatically generates 24px monochrome icons from the 22px
versions for
action, device, places, and status icons by editing the SVG files to increase
the size
of the viewbox and apply a (1,1) translation to the content.
That way I implemented this seems to work pretty reliably on the icon
generation side.
However I am less sure about how it is integrated into the CMake files. It
works, but if
I did it wrong, let me know.
TEST PLAN
Delete `~/kde/usr/share/icons/{breeze,breeze-dark}` (or wherever your icons
live)
Apply patch and build
Look in
`~/kde/usr/share/icons/{breeze,breeze-dark}/{devices,actions,places,status}/24`
Open Cuttlefish
See that everything is awesome
REPOSITORY
R266 Breeze Icons
BRANCH
autogenerate-24px-icons (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D27557
AFFECTED FILES
generate-24px-versions.sh
icons-dark/CMakeLists.txt
icons-dark/actions/24/acrobat.svg
icons-dark/actions/24/activities.svg
icons-dark/actions/24/address-book-new.svg
icons-dark/actions/24/align-horizontal-baseline.svg
icons-dark/actions/24/align-horizontal-bottom-out.svg
icons-dark/actions/24/align-horizontal-center.svg
icons-dark/actions/24/align-horizontal-left-out.svg
icons-dark/actions/24/align-horizontal-left-to-anchor.svg
icons-dark/actions/24/align-horizontal-left.svg
icons-dark/actions/24/align-horizontal-node.svg
icons-dark/actions/24/align-horizontal-right-out.svg
icons-dark/actions/24/align-horizontal-right-to-anchor.svg
icons-dark/actions/24/align-horizontal-right.svg
icons-dark/actions/24/align-horizontal-top-out.svg
icons-dark/actions/24/align-vertical-baseline.svg
icons-dark/actions/24/align-vertical-bottom-out.svg
icons-dark/actions/24/align-vertical-bottom-to-anchor.svg
icons-dark/actions/24/align-vertical-bottom.svg
icons-dark/actions/24/align-vertical-center.svg
icons-dark/actions/24/align-vertical-node.svg
icons-dark/actions/24/align-vertical-top-out.svg
icons-dark/actions/24/align-vertical-top-to-anchor.svg
icons-dark/actions/24/align-vertical-top.svg
icons-dark/actions/24/amarok_cart_view.svg
icons-dark/actions/24/application-exit.svg
icons-dark/actions/24/application-menu.svg
icons-dark/actions/24/appointment-new.svg
icons-dark/actions/24/archive-extract.svg
icons-dark/actions/24/archive-insert-directory.svg
icons-dark/actions/24/archive-insert.svg
icons-dark/actions/24/archive-remove.svg
icons-dark/actions/24/arrow-down-double.svg
icons-dark/actions/24/arrow-down.svg
icons-dark/actions/24/arrow-left-double.svg
icons-dark/actions/24/arrow-left.svg
icons-dark/actions/24/arrow-right-double.svg
icons-dark/actions/24/arrow-right.svg
icons-dark/actions/24/arrow-up-double.svg
icons-dark/actions/24/arrow-up.svg
icons-dark/actions/24/audio-volume-high.svg
icons-dark/actions/24/audio-volume-low.svg
icons-dark/actions/24/audio-volume-medium.svg
icons-dark/actions/24/audio-volume-muted.svg
icons-dark/actions/24/auto-scale-all.svg
icons-dark/actions/24/auto-scale-x.svg
icons-dark/actions/24/auto-scale-y.svg
icons-dark/actions/24/autocorrection.svg
icons-dark/actions/24/bookmark-new-list.svg
icons-dark/actions/24/bookmark-new.svg
icons-dark/actions/24/bookmark-toolbar.svg
icons-dark/actions/24/bookmarks-organize.svg
icons-dark/actions/24/bookmarks.svg
icons-dark/actions/24/bordertool.svg
icons-dark/actions/24/call-start.svg
icons-dark/actions/24/call-stop.svg
icons-dark/actions/24/character-set.svg
icons-dark/actions/24/checkbox.svg
icons-dark/actions/24/chronometer-lap.svg
icons-dark/actions/24/chronometer-pause.svg
icons-dark/actions/24/chronometer-reset.svg
icons-dark/actions/24/chronometer-start.svg
icons-dark/actions/24/chronometer.svg
icons-dark/actions/24/class-or-package.svg
icons-dark/actions/24/code-block.svg
icons-dark/actions/24/code-class.svg
icons-dark/actions/24/code-context.svg
icons-dark/actions/24/code-function.svg
icons-dark/actions/24/code-typedef.svg
icons-dark/actions/24/code-variable.svg
icons-dark/actions/24/collapse-all.svg
icons-dark/actions/24/color-fill.svg
icons-dark/actions/24/color-gradient.svg
icons-dark/actions/24/color-management.svg
icons-dark/actions/24/color-picker-black.svg
icons-dark/actions/24/color-picker-grey.svg
icons-dark/actions/24/color-picker-white.svg
icons-dark/actions/24/color-picker.svg
icons-dark/actions/24/colormanagement.svg
icons-dark/actions/24/configure-shortcuts.svg
icons-dark/actions/24/configure-toolbars.svg
icons-dark/actions/24/configure.svg
icons-dark/actions/24/contact-new.svg
icons-dark/actions/24/contrast.svg
icons-dark/actions/24/cursor-arrow.svg
icons-dark/actions/24/dashboard-show.svg
icons-dark/actions/24/database-change-key.svg
icons-dark/actions/24/database-index.svg
icons-dark/actions/24/debug-execute-from-cursor.svg
icons-dark/actions/24/debug-execute-to-cursor.svg
icons-dark/actions/24/debug-run-cursor.svg
icons-dark/actions/24/debug-run.svg
icons-dark/actions/24/debug-step-instruction.svg
icons-dark/actions/24/debug-step-into-instruction.svg
icons-dark/actions/24/debug-step-into.svg
icons-dark/actions/24/debug-step-out.svg
icons-dark/actions/24/debug-step-over.svg
icons-dark/actions/24/dialog-cancel.svg
icons-dark/actions/24/dialog-close.svg
icons-dark/actions/24/dialog-messages.svg
icons-dark/actions/24/dialog-ok-apply.svg
icons-dark/actions/24/dialog-ok.svg
icons-dark/actions/24/dialog-xml-editor.svg
icons-dark/actions/24/dirsync.svg
icons-dark/actions/24/distribute-graph-directed.svg
icons-dark/actions/24/distribute-graph.svg
icons-dark/actions/24/distribute-horizontal-baseline.svg
icons-dark/actions/24/distribute-horizontal-center.svg
icons-dark/actions/24/distribute-horizontal-equal.svg
icons-dark/actions/24/distribute-horizontal-gaps.svg
icons-dark/actions/24/distribute-horizontal-left.svg
icons-dark/actions/24/distribute-horizontal-margin.svg
icons-dark/actions/24/distribute-horizontal-node.svg
icons-dark/actions/24/distribute-horizontal-page.svg
icons-dark/actions/24/distribute-horizontal-right.svg
icons-dark/actions/24/distribute-horizontal-x.svg
icons-dark/actions/24/distribute-horizontal.svg
icons-dark/actions/24/distribute-randomize.svg
icons-dark/actions/24/distribute-remove-overlaps.svg
icons-dark/actions/24/distribute-unclump.svg
icons-dark/actions/24/distribute-vertical-baseline.svg
icons-dark/actions/24/distribute-vertical-bottom.svg
icons-dark/actions/24/distribute-vertical-center.svg
icons-dark/actions/24/distribute-vertical-equal.svg
icons-dark/actions/24/distribute-vertical-gaps.svg
icons-dark/actions/24/distribute-vertical-margin.svg
icons-dark/actions/24/distribute-vertical-node.svg
icons-dark/actions/24/distribute-vertical-page.svg
icons-dark/actions/24/distribute-vertical-top.svg
icons-dark/actions/24/distribute-vertical-y.svg
icons-dark/actions/24/distribute-vertical.svg
icons-dark/actions/24/document-close.svg
icons-dark/actions/24/document-decrypt.svg
icons-dark/actions/24/document-edit-decrypt-verify.svg
icons-dark/actions/24/document-edit-decrypt.svg
icons-dark/actions/24/document-edit-encrypt.svg
icons-dark/actions/24/document-edit-sign-encrypt.svg
icons-dark/actions/24/document-edit-sign.svg
icons-dark/actions/24/document-edit-verify.svg
icons-dark/actions/24/document-edit.svg
icons-dark/actions/24/document-encrypt.svg
icons-dark/actions/24/document-encrypted.svg
icons-dark/actions/24/document-export-table.svg
icons-dark/actions/24/document-export.svg
icons-dark/actions/24/document-import.svg
icons-dark/actions/24/document-multiple.svg
icons-dark/actions/24/document-new-from-template.svg
icons-dark/actions/24/document-new.svg
icons-dark/actions/24/document-open-folder.svg
icons-dark/actions/24/document-open-recent.svg
icons-dark/actions/24/document-open-remote.svg
icons-dark/actions/24/document-open.svg
icons-dark/actions/24/document-preview-archive.svg
icons-dark/actions/24/document-preview.svg
icons-dark/actions/24/document-print-direct.svg
icons-dark/actions/24/document-print-frame.svg
icons-dark/actions/24/document-print-preview.svg
icons-dark/actions/24/document-print.svg
icons-dark/actions/24/document-properties.svg
icons-dark/actions/24/document-revert.svg
icons-dark/actions/24/document-save-all.svg
icons-dark/actions/24/document-save-as-template.svg
icons-dark/actions/24/document-save-as.svg
icons-dark/actions/24/document-save.svg
icons-dark/actions/24/document-share.svg
icons-dark/actions/24/document-sign.svg
icons-dark/actions/24/document-swap.svg
icons-dark/actions/24/documentation.svg
icons-dark/actions/24/documentinfo.svg
icons-dark/actions/24/download-later.svg
icons-dark/actions/24/download.svg
icons-dark/actions/24/draw-arrow-back.svg
icons-dark/actions/24/draw-arrow-down.svg
icons-dark/actions/24/draw-arrow-forward.svg
icons-dark/actions/24/draw-arrow-up.svg
icons-dark/actions/24/draw-bezier-curves.svg
icons-dark/actions/24/draw-brush.svg
icons-dark/actions/24/draw-calligraphic.svg
icons-dark/actions/24/draw-circle.svg
icons-dark/actions/24/draw-connector.svg
icons-dark/actions/24/draw-cross.svg
icons-dark/actions/24/draw-cuboid.svg
icons-dark/actions/24/draw-donut.svg
icons-dark/actions/24/draw-ellipse.svg
icons-dark/actions/24/draw-eraser.svg
icons-dark/actions/24/draw-freehand.svg
icons-dark/actions/24/draw-halfcircle1.svg
icons-dark/actions/24/draw-halfcircle2.svg
icons-dark/actions/24/draw-halfcircle3.svg
icons-dark/actions/24/draw-halfcircle4.svg
icons-dark/actions/24/draw-line.svg
icons-dark/actions/24/draw-path.svg
icons-dark/actions/24/draw-polygon-star.svg
icons-dark/actions/24/draw-polygon.svg
icons-dark/actions/24/draw-polyline.svg
icons-dark/actions/24/draw-rectangle.svg
icons-dark/actions/24/draw-spiral.svg
icons-dark/actions/24/draw-square-inverted-corners.svg
icons-dark/actions/24/draw-star.svg
icons-dark/actions/24/draw-text.svg
icons-dark/actions/24/draw-triangle.svg
icons-dark/actions/24/draw-triangle1.svg
icons-dark/actions/24/draw-triangle2.svg
icons-dark/actions/24/draw-triangle3.svg
icons-dark/actions/24/draw-triangle4.svg
icons-dark/actions/24/draw-watercolor.svg
icons-dark/actions/24/edit-bomb.svg
icons-dark/actions/24/edit-clear-all.svg
icons-dark/actions/24/edit-clear-history.svg
icons-dark/actions/24/edit-clear-list.svg
icons-dark/actions/24/edit-clear-locationbar-ltr.svg
icons-dark/actions/24/edit-clear-locationbar-rtl.svg
icons-dark/actions/24/edit-clear.svg
icons-dark/actions/24/edit-clone.svg
icons-dark/actions/24/edit-copy.svg
icons-dark/actions/24/edit-cut.svg
icons-dark/actions/24/edit-delete-shred.svg
icons-dark/actions/24/edit-delete.svg
icons-dark/actions/24/edit-download.svg
icons-dark/actions/24/edit-find-mail.svg
icons-dark/actions/24/edit-find-project.svg
icons-dark/actions/24/edit-find-replace.svg
icons-dark/actions/24/edit-find-user.svg
icons-dark/actions/24/edit-find.svg
icons-dark/actions/24/edit-group.svg
icons-dark/actions/24/edit-guides.svg
icons-dark/actions/24/edit-image-face-add.svg
icons-dark/actions/24/edit-image-face-detect.svg
icons-dark/actions/24/edit-image-face-recognize.svg
icons-dark/actions/24/edit-image-face-show.svg
icons-dark/actions/24/edit-node.svg
icons-dark/actions/24/edit-none.svg
icons-dark/actions/24/edit-paste-in-place.svg
icons-dark/actions/24/edit-paste.svg
icons-dark/actions/24/edit-redo.svg
icons-dark/actions/24/edit-rename.svg
icons-dark/actions/24/edit-select-all.svg
icons-dark/actions/24/edit-select-invert.svg
icons-dark/actions/24/edit-select-lasso.svg
icons-dark/actions/24/edit-select-none.svg
icons-dark/actions/24/edit-select.svg
icons-dark/actions/24/edit-table-cell-merge.svg
icons-dark/actions/24/edit-table-cell-split.svg
icons-dark/actions/24/edit-table-delete-column.svg
icons-dark/actions/24/edit-table-delete-row.svg
icons-dark/actions/24/edit-table-insert-column-left.svg
icons-dark/actions/24/edit-table-insert-column-right.svg
icons-dark/actions/24/edit-table-insert-row-above.svg
icons-dark/actions/24/edit-table-insert-row-below.svg
(1780 more files...)
To: ngraham, #vdg, ndavis, #frameworks, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
