sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.
I've changed 417069 to CCBUG only, there's more to that issue than just the
bogus fallback in this function.
Diff LGTM, besides one minor comment about not keeping that QLatin1String.
INLINE COMMENTS
> global.cpp:227
> if (url.scheme().isEmpty()) { // empty URL or relative URL (e.g. '~')
> - return unknown;
> + return QLatin1String ("unknown");
> }
I think we can QStringLiteral this. QLatin1String has no performance advantage
when it gets type converted to QString anyway.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D27539
To: meven, ngraham, #frameworks, dfaure, broulik, sitter
Cc: sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,
bruns
