mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in Button.qml:62
> I don't understand this part about constraining the width to the parent 
> height  (for all 3)
> 
> If I remove it all the tests still pass.

was an extra constraint to have buttons always square, but i added some test 
and removed this , they seem to behave always well without it

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27460

To: mart, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

Reply via email to