cfeck added inline comments.
INLINE COMMENTS
> kmessagewidget.cpp:155
> };
> -
> + // Add bordersize to the margin so it starts from the inner border and
> doesn't look to cramped
> + q->layout()->setContentsMargins(q->layout()->contentsMargins() +
> borderSize);
too
> kmessagewidget.cpp:193
> + textLabel->setPalette(palette);
> + // update the Icon in case its recolorable
> + q->setIcon(icon);
typo: it is
> kmessagewidget.cpp:325
> + constexpr float radius = 4 * 0.6;
> + const QRect innerRect = rect().marginsRemoved(QMargins() + borderSize/2);
> + const QColor color = palette().color(QPalette::Window);
missing spaces around `/`
> kmessagewidget.cpp:397
>
> - if (isVisible() && (d->timeLine->state() == QTimeLine::NotRunning) &&
> (height() == d->bestContentHeight()) && (d->content->pos().y() == 0)) {
> + if (isVisible() && (d->timeLine->state() == QTimeLine::NotRunning) &&
> (height() == d->bestContentHeight())){
> emit showAnimationFinished();
missing space before `{`
REPOSITORY
R236 KWidgetsAddons
BRANCH
no-css (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D27035
To: davidre, #frameworks, ngraham
Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2,
michaelh, bruns
