albertvaka added inline comments. INLINE COMMENTS
> notifybysnore.cpp:135-139 > + if (id == -1) { > + emit actionInvoked(0, actionNum); > + } else { > + emit actionInvoked(id, actionNum); > + } This could become: if (id == -1) { id = 0 } emit actionInvoked(id, actionNum); To not duplicate the emit line. Still, it feels hackish. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26888 To: brute4s99, vonreth, broulik, #kde_connect Cc: albertvaka, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns