dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> statjob.cpp:97
> +
> +void StatJob::setDetails(short int details)
> +{
When the declaration is in #if, the definition should be too (with
s/ENABLED/BUILD/).
#if KIOCORE_BUILD_DEPRECATED_SINCE(5, 68)
> statjob.h:79
> + void setDetails(KIO::StatDetails details);
> + void setDetails(KIO::StatDetail detail);
> +
I guess this overload exists because of the setDetails(short int) overload?
(QFlags has an implicit constructor from Enum so usually we don't need a
single-flag overload)
If so, I suppose we can get rid of it for Qt6.
Or when KIOCORE_ENABLE_DEPRECATED_SINCE(5, 68) isn't set.
So basically it could move into an #else section of the #if below?
> dfaure wrote in statjob.h:226
> Why does this say "int" after "StatDetails"?
This was marked as done, but I still see ", KIO::StatDetails int,"
> dfaure wrote in statjob.h:234
> Typo: direcly -> directly (happens again two lines down)
Still there
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D25010
To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
