cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land.
I think we can go with this as is. Given we have tests for a lot of stuff, regressions shouldn't be that likely. I will merge this, before we let that rot even more. Thanks for the work on this, btw.! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24982 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann