ndavis marked 5 inline comments as done. ndavis added inline comments. INLINE COMMENTS
> mwoehlke wrote in kcolorutils.h:36 > "0.999..." is a little odd, and I wonder if it is accurate for e.g. > `QColor::fromRgba64(0xffff, 0, 1}`? Maybe something like "just under 1.0 > (also red)" would be more useful? (If you want to get technical, "to > (asymptotically) 1.0" would also work. Maybe "0.0 //approaching// 1.0"?) > > The range is of course [0, 1), but I don't know how to say that in > straight-forward English 🙂. > > OTOH, I wonder if it's worth bothering, vs. just saying "0.0 to 1.0" and > ignoring that it will never be //exactly// 1.0. > from 0.0 (red) to almost 1.0 (slightly blue-ish red) This sounds good to me. I think it's worth saying that it won't be 1.0 so that people don't assume the number is a rounding error or something. REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D27017 To: ndavis, #frameworks, dfaure Cc: mwoehlke, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
