pdabrowski added a comment.

  In D27148#605830 <https://phabricator.kde.org/D27148#605830>, @marten wrote:
  
  > Yes, I'd concluded that the real place to fix the problem was at the KParts 
level, but not being a KParts expert wanted to leave that decision to its 
maintainers.  +1 for the elegant fix.
  
  
  I'm in no case KParts expert. That's why I would like a maintainer to review 
this change.
  Especially I'm not sure if it is ok to use KIO::StatJob here.
  
  > One coding style change? - mostLocalUrl(QUrl url) -> mostLocalUrl(const 
QUrl &url)
  
  Good catch. I will fix it.

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D27148

To: pdabrowski, elvisangelaccio, ngraham
Cc: marten, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Reply via email to