gvgeo removed a reviewer: ndavis. gvgeo added a subscriber: ndavis. gvgeo added a comment.
In D27082#604556 <https://phabricator.kde.org/D27082#604556>, @ndavis wrote: > poor horizontal alignment Don't make me redraw PC3 tests too. The basis of the issue is the same, different Label than Button height. For PC3 label is shorter than buttons. In D26758#604416 <https://phabricator.kde.org/D26758#604416>, @gvgeo wrote: > F8071207: alignment.png <https://phabricator.kde.org/F8071207> > This shows the problem. > Don't know what is the correct approach: > 1 Label needs to be shorter. > 2 Give correct height in checkbox, and center the buttons. > 3 Override label height in radiobutton, to make everything slim. Will need to center when used. Either need to increase label height to button height, or need to center label in the test (and everywhere else it is used.) --- In D27082#604557 <https://phabricator.kde.org/D27082#604557>, @ndavis wrote: > Well, it has the correct size in that it's 16x16, but it's like it was stretched and crop Others would say "The position of the left side is off by half a pixel". The cause of it and solution, as I interpret them is D27083 <https://phabricator.kde.org/D27083>. --- In D27082#604556 <https://phabricator.kde.org/D27082#604556>, @ndavis wrote: > I'm not really the best person to review this I made these 2 patches based on your feedback, and thought it would be a good idea to see them. There, fixed it :) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27082 To: gvgeo, #plasma Cc: ndavis, kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, michaelh, ZrenBot, ngraham, bruns, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
