ndavis marked an inline comment as done.
ndavis added inline comments.

INLINE COMMENTS

> broulik wrote in kcolorutils.h:42
> This doesn't mention hcy anywhere and there's `QColor::hue`. 
> But we already have `luma` in the same way, so I guess this is alright.

Hue in this implementation of HCY is similar, but not the same as hue in HSV or 
HSL. For instance, the hue of `#232629` is 0.587279 in HCY and 0.583333 in 
HSV/HSL.

Luma and chroma are also different than value/lightness or HSV/HSL saturation.

REPOSITORY
  R273 KGuiAddons

REVISION DETAIL
  https://phabricator.kde.org/D27017

To: ndavis, #frameworks, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Reply via email to