ahiemstra added inline comments.

INLINE COMMENTS

> ksortfilterproxymodel.cpp:85
> +        QJSValueList args = {QJSValue(source_column), 
> engine->toScriptValue(source_parent)};
> +        return const_cast<KSortFilterProxyModel 
> *>(this)->m_filterCallback.call(args).toBool();
> +    }

This is using the wrong callback, it should be using m_filterColumnCallback

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D25326

To: davidedmundson
Cc: kmaterka, iasensio, ahmadsamir, broulik, ahiemstra, mart, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Reply via email to