trmdi marked 3 inline comments as done. trmdi added inline comments. INLINE COMMENTS
> davidedmundson wrote in containmentinterface.cpp:548 > can you be sure urls has at least 1 at this point? Yes, because all `clearDataForMimeJob` are called from inside of `mimeTypeRetrieved` which is only called from here: https://phabricator.kde.org/source/plasma-framework/browse/master/src/scriptengines/qml/plasmoid/containmentinterface.cpp$454 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26691 To: trmdi, #plasma, mart, broulik, #vdg, davidedmundson Cc: davidedmundson, anthonyfieroni, #plasma, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns