meven added inline comments. INLINE COMMENTS
> dfaure wrote in kmountpoint.cpp:443 > Why reuse and assign, compared to just `const QFileInfo fileinfo(parentPath)`? > > (Same for parentPath -- I prefer C++ over C) I expected reviewers to tell to have declaration outside of loops... > dfaure wrote in kmountpoint.cpp:447 > Wouldn't .mid() be faster than split+join? Just wondering. I see why you need > to split, just wondering about join.. I am pretty sure a mid operation would be faster. It was just that algorithmic-wise it was clearer and faster to put together for me. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26407 To: meven, #frameworks, ngraham, broulik, dfaure Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
