dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > kcoredirlister.cpp:2306 > + d->settings.lstFilters.append(QRegularExpression( > + > QRegularExpression::anchoredPattern(QRegularExpression::wildcardToRegularExpression(filter)), > + QRegularExpression::CaseInsensitiveOption)); I think you said this would anchor twice, in another review? Needs to be fixed then. (Good for readability!) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26659 To: ahmadsamir, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
