dfaure added inline comments.

INLINE COMMENTS

> wsdiscoverer.cpp:97
> +        while (!m_discovery) {
> +            QCoreApplication::processEvents();
> +        }

You could also connect the signal resolved() to a local QEventLoop here? Would 
be cleaner and less CPU-intensive.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D25682

To: sitter, dfaure, #frameworks, #dolphin
Cc: meven, schmeisser, bcooksley, ngraham, caspermeijn, davidedmundson, 
kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov

Reply via email to