dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land.
You can land after making these last minute adjustments, no need for another round of review :) INLINE COMMENTS > dropjob.h:83 > + * @since 5.67 > + **/ > + void showMenu(const QPoint &p, QAction *atAction = nullptr); Nitpick: normally it's a single star on the last line. Dunno if it matters for doxygen. > dropjob.h:163 > + * @since 5.67 > + **/ > +KIOWIDGETS_EXPORT DropJob *drop(const QDropEvent *dropEvent, const QUrl > &destUrl, DropJobFlags dropjobFlags, JobFlags flags = DefaultFlags); // BCI: > merge with DropJobFlags dropjobFlag = DropJobDefaultFlags (same) > dropjob.h:164 > + **/ > +KIOWIDGETS_EXPORT DropJob *drop(const QDropEvent *dropEvent, const QUrl > &destUrl, DropJobFlags dropjobFlags, JobFlags flags = DefaultFlags); // BCI: > merge with DropJobFlags dropjobFlag = DropJobDefaultFlags > + BIC = Binary Incompatible Change. What's BCI? In any case better add "TODO KF6" to the comment, I'm sure we'll be grepping for that when the time comes (rather than BCI/BIC). REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: ngraham, broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
