tcanabrava updated this revision to Diff 73336. tcanabrava marked 4 inline comments as done. tcanabrava added a comment.
- Rename KConfigCodeGenerator to KconfigCodeGeneratorBase - Simplify diff file saving - Add License Headers - Documentation, Privatization, Unused method / variable - Const, Documentation - Newlines at the end of files - Spacing - Remove Globals - Remove unused code and Debugs - Constify ParseResult - English Typos - qAsConst - Public / Private issues - Simplify Construction - Revert "Constify ParseResult" REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26202?vs=73310&id=73336 BRANCH arcpatch-D26202 REVISION DETAIL https://phabricator.kde.org/D26202 AFFECTED FILES autotests/kconfig_compiler/kconfigcompiler_test.cpp autotests/kconfig_compiler/test1.h.ref autotests/kconfig_compiler/test10.h.ref autotests/kconfig_compiler/test11.h.ref autotests/kconfig_compiler/test11a.h.ref autotests/kconfig_compiler/test12.h.ref autotests/kconfig_compiler/test13.h.ref autotests/kconfig_compiler/test9.h.ref autotests/kconfig_compiler/test_dpointer.cpp.ref autotests/kconfig_compiler/test_translation_kde.h.ref autotests/kconfig_compiler/test_translation_kde_domain.h.ref autotests/kconfig_compiler/test_translation_qt.h.ref autotests/kconfigtest.h src/kconfig_compiler/CMakeLists.txt src/kconfig_compiler/KCFGXmlParser.cpp src/kconfig_compiler/KCFGXmlParser.h src/kconfig_compiler/KConfigCodeGeneratorBase.cpp src/kconfig_compiler/KConfigCodeGeneratorBase.h src/kconfig_compiler/KConfigCommonStructs.h src/kconfig_compiler/KConfigHeaderGenerator.cpp src/kconfig_compiler/KConfigHeaderGenerator.h src/kconfig_compiler/KConfigSourceGenerator.cpp src/kconfig_compiler/KConfigSourceGenerator.h src/kconfig_compiler/KConfigXTParameters.cpp src/kconfig_compiler/KConfigXTParameters.h src/kconfig_compiler/kconfig_compiler.cpp To: tcanabrava, #frameworks, ervin, bport, dfaure Cc: bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns