kossebau added inline comments.

INLINE COMMENTS

> containmentactions.h:67
>  
> +#if PLASMA_ENABLE_DEPRECATED_SINCE(5, 64)
>      /**

The visibility wrappers also need bumping to 5, 67, so the version were the API 
got deprecated, to not break things for people who use 
*_DISABLE_DEPRECATED_BEFORE_AND_AT with 5.64-5.66 and who still use this API.

Will fix directly now. just mentioning here as reminder for future similar 
deprecation patches.

And yes, this data duplication sucks, but no-one found a way around yet for 
this macro magic to have the features of control both about visibility and 
warnings separately.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23682

To: apol, #plasma, mart
Cc: kossebau, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

Reply via email to