broulik added a comment.

  I don't fully understand why `popupMenuAboutToShow` isn't sufficient.
  An alternative approach I could think would be allowing the signal handler to 
delay the menu as necessary rather than having to create the drop job 
differently?

INLINE COMMENTS

> dropjob.h:131
>  
> +KIOWIDGETS_EXPORT DropJob *drop(const QDropEvent *dropEvent, const QUrl 
> &destUrl, bool delayPopup, JobFlags flags = DefaultFlags);
> +

`bool` arguments are generally frowned upon. Perhaps introduce a flag instead.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26484

To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure
Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

Reply via email to