bport added inline comments. INLINE COMMENTS
> ervin wrote in kpluginselector.cpp:389 > This logic looks wrong to me. > > isChanged indicates if an entry state was changed during the course of the > call to defaults(). It's very possible it's false when getting out of the > loop. > If that's the case we will emit changed(false). But the changed() signal here > indicates if we have a state different from the last load() call. > > I think in such a case we'd loose the information of being in a "dirty" state > while defaults() wouldn't have changed state at all. isPluginEnabled represent the current state (i.e. after load) so we compare the file value with default value > ervin wrote in kpluginselector_p.h:205 > Either this is unused or this doesn't compile/run properly. Indeed, this > signature changed but no other code has been adjusted to match it. The method declaration changed and the connected slot already provide the value REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D26466 To: bport, #plasma, ervin, crossi, meven Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
