dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > jobtest.cpp:2075 > + QThread::msleep(500); > + QVERIFY(!QFile::exists(destToCheck)); > } How about QTRY_VERIFY instead of a hardcoded 500ms sleep? This way, if the file gets deleted after 100ms, we can move on. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25117 To: meven, #frameworks, dfaure, ngraham, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
