meven added inline comments.

INLINE COMMENTS

> broulik wrote in kfileitem.cpp:783
> This creates a `QFileInfo` for `canonicalFilePath` which blocks, so the cache 
> doesn't help at all.

At least the mnttab reading business in KMountPoint::currentMountPoints is 
saved.

> anthonyfieroni wrote in kfileitem.cpp:787
> Empty mountPoints means no fstab.

Here I am using KMountPoint::currentMountPoints which uses mnttab which should 
be supported on *nix.
The part about android came from KMountPoint::currentMountPoints comment.

I was thing about merging the two KMountPoint::currentMountPoints and 
KMountPoint::possibleMountPoints for better accuracy.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26407

To: meven, #frameworks, ngraham, broulik, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

Reply via email to