kossebau added inline comments. INLINE COMMENTS
> broulik wrote in ktoolbar.cpp:908 > I just realized this is false-y deprecated. The feature adds the > configuration options for toolbar buttons. > What needs to be done here for proper deprecation is port that over to > `customContextMenuRequested` or checking for policy being not `NoContextMenu` > or so. For reference: Deprecation of custom context menu enabling methods in favor of QWidget::contextMenuPolicy was done 2007: R446:41c7dd48afbf2794dbe260466d569d808d851c04 <https://phabricator.kde.org/R446:41c7dd48afbf2794dbe260466d569d808d851c04> And implementation code wrapped in 2010: R446:52905e8d94ee6d7a08ff1b793c5dd226f0c3fbc1 <https://phabricator.kde.org/R446:52905e8d94ee6d7a08ff1b793c5dd226f0c3fbc1> Guess best is to add a TODO into the code for now, unless you are already on it? REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D24466 To: kossebau, #frameworks, dfaure, mlaurent Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
