----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114922/#review47122 -----------------------------------------------------------
Ship it! All looks sane to me (and I can't see anything obvious that would cause any regressions). src/kwindoweffects_dummy.cpp <https://git.reviewboard.kde.org/r/114922/#comment33579> Sort of orthogonal to the change, but is it worth doing windowSizes.reserve(ids.count()) here? - Alex Merry On Jan. 9, 2014, 9:03 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114922/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2014, 9:03 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kwindowsystem > > > Description > ------- > > So far KWindowEffects had a compile time switch. Either it got compiled > for X11 or a dummy implementation got used. The actual runtime platform > got not considered at all. This change ensures that the X11 > implementation is only used if the runtime platform is xcb. So if for > example one uses Wayland, but KWindowSystem got compiled with X11 > support the dummy implementation is picked. > > To achieve that a new pure virtual KWindowEffectsPrivate class is > introduced which has two implementations: KWindowEffectsPrivateDummy > and KWindowEffectsPrivateX11. > > A new implementation for KWindowEffects is added which uses a global > static which holds a pointer to the KWindowEffectsPrivate. Thus the > global static functions acts as a factory method to pick the proper > implementation for the runtime system. The implementation of the > methods just delegate to the respective method of > KWindowEffectsPrivate. > > > Diffs > ----- > > src/CMakeLists.txt 6a500fe9b257d8ff1871e799f7cdcd880de06128 > src/kwindoweffects.cpp PRE-CREATION > src/kwindoweffects_dummy.cpp ce3b9bf4405d1befe3e36d3ede0a4bafe81d850d > src/kwindoweffects_p.h PRE-CREATION > src/kwindoweffects_x11.cpp b71e6b9f30d2f02ea86aa58b0b135a206904af7b > > Diff: https://git.reviewboard.kde.org/r/114922/diff/ > > > Testing > ------- > > X11 unit test is working > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
