----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114908/ -----------------------------------------------------------
Review request for Build System and KDE Frameworks. Repository: extra-cmake-modules Description ------- Use add_definitions directly, instead of via _KDE4_PLATFORM_DEFINITIONS Setting the variable just leads to set() calls overwriting each other accidentally (as appeared to have happened in the WIN32 block). Diffs ----- kde-modules/KDECompilerSettings.cmake 6adbc069bf314ae1a462ffbc5abe25264dac0ac2 Diff: https://git.reviewboard.kde.org/r/114908/diff/ Testing ------- KCoreAddons still compiles, and "make VERBOSE=1" shows that it is setting -D_BSD_SOURCE -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500, as expected. Thanks, Alex Merry
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
