----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114903/#review47016 -----------------------------------------------------------
This review has been submitted with commit eb7cdf3cbdf11f22a33989b5dc2c09da31a07858 by Alex Merry to branch master. - Commit Hook On Jan. 7, 2014, 8:57 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114903/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2014, 8:57 p.m.) > > > Review request for Build System, KDE Frameworks and Stephen Kelly. > > > Repository: extra-cmake-modules > > > Description > ------- > > Do not set CMP0022 > > We do not want to suppress any warnings about LINK_INTERFACE_LIBRARIES > vs INTERFACE_LINK_LIBRARIES; everything should be using the latter, > since we depend on CMake 2.8.12 everywhere. > > > Diffs > ----- > > kde-modules/KDECMakeSettings.cmake 63cc90117a0a0655fa6e1db0f054235bb6333f29 > > Diff: https://git.reviewboard.kde.org/r/114903/diff/ > > > Testing > ------- > > CMake runs fine (in a clean build dir) on KCoreAddons, KActivities (which > still triggers the warning, but I don't think includes this file anyway) and > plasma-frameworks. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
