On Thursday 02 January 2014 14:06:47 Kevin Ottens wrote: > On Thursday 02 January 2014 12:25:47 David Faure wrote: > > On Thursday 02 January 2014 11:35:43 David Faure wrote: > > > See attached patch. > > > > I forgot to attach the corresponding patch for ECM. > > > > Tested on KParts too, with the addition of a "PREFIX" variable. > > > > MODULE_NAME = KParts or KIOCore .. the include dir under KF5, always > > titlecase PREFIX = KParts or KIO, the subdir inside MODULE_NAME for > > namespaced headers, gets lowercased for lowercase headers. > > > > include/KF5/KParts/KParts/BrowserExtension > > include/KF5/KParts/kparts/browserextension.h > > > > Awaiting for green light. > > That would be for the namespaced frameworks only right? > > We still plan to have: > include/KF5/KCoreAddons/kjob.h > include/KF5/KCoreAddons/KJob > For the non namespace case?
Yes. include/KF5/MODULE_NAME/the_thing_to_include where the_thing_to_include can include a prefix (namespaced headers) or not (non-namespaced headers). I can see how it looks like duplication when the prefix is equal to the module name, but since it's not always the case (KIOCore vs KIO) and since there isn't always a prefix (non-namespaced headers), I think this makes things consistent. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
