On Monday 30 December 2013 18:54:45 Hugo Pereira Da Costa wrote: > No no: in KDE4, oxygen was not inheriting from KStyle but QCommonStyle. > In KF5 it is inheriting again from the (much cleaned-up) KStyle class. > So that I'm all for moving it (or any KF5 equivalent) to KStyle. > (just not the way it is done now ;))
Sounds good. > > Shall we keep the same idea for KF5 or move it up to KStyle? > > > > I guess globalPaletteChanged() was in oxygen, but the reparsing done > > inside > > kglobalsettings made things work in kstyle too. > > yes. But should be avoided. > I'll look into it a bot (but Alex might now better). Great, I'll let you two sort it out then :) The commits I showed should give inspiration :) > In the meanwhile, I would just comment out the reparsing (which in turn > would imply that configuration changes would only apply to newly started > applciations, but I guess that's better than having unresponsive > applications ...) I completely agree. Reverted. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
