On 11/29/2013 12:22 PM, Kevin Ottens wrote:
On Friday 29 November 2013 12:00:38 Christoph Feck wrote:
On Friday 29 November 2013 08:53:06 Kevin Ottens wrote:
KColorDialog and KFontDialog are out of the picture. We contributed
to the upstream QColorDialog and QFontDialog so that they have the
features we needed out of the box. We only need to do something
for the file dialog.
Not sure if we can silently drop the K classes.

KFontDialog:
- allows the application to specify a list of fonts to show
To upstream if that's used (IIRC we didn't find users of that).

- allows the application to request fixed-width fonts only
That's upstream.

- allows limiting to only change family, style, or size
To upstream if that's used (IIRC almost no user again).
If I understand right, this is really usefull in KCM font selection when you want to change all fonts at once, but for instance only the size.
Would be quite an issue if this was to go ...



- supports fractional point sizes, e.g. 9.4 pt.
To upstream if needed.

- word wraps and scrolls big sample texts
To upstream.

KColorDialog:
- allows the application to specify a default color, where the user
can revert to
To upstream.

- supports both RGB and HSV color models
Looks like QColorDialog does too, or I'm missing something?

- has support for loadable palettes (editable via kcoloredit)
OK, that one is indeed missing. And if we want to upstream that it'll require
more work than the rest.

- appearantly the color picker and hex line edit have been upstreamed,
but I just tried Qt 5.3 Designer, and those features did not appear.
Odd, I see them here.


Overall my point is that it's mostly features which really belongs upstream.
And they're either stuff we can contribute at any point or stuff which is
unused. The only exception seems to be the loadable palettes, but that's not
enough to warrant having a full fledged color dialog on our side IMO. So if
that's really important, it's something to design properly to be able to plug
those loadable palettes into QColorDialog.

Regards.


_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Reply via email to