----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114185/#review44766 -----------------------------------------------------------
We need something similar (without linking to kde4support though) for the file dialog. But we don't want that for font dialog though. - Kevin Ottens On Nov. 28, 2013, 6:03 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114185/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2013, 6:03 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > To brighten a bit further the e-mail I just sent to kde-framewo...@kde.org, > here I'm making the PlatformTheme to use our KFontDialog, that now it's > residing in KDE4Support. > > I'd say this should result in a new module created, since we don't want to > depend on KDE4Support, although I can see how we don't want to maintain an > ABI on those classes, so forking is an option too. > > > Diffs > ----- > > tier4/frameworkintegration/CMakeLists.txt 02b3563 > tier4/frameworkintegration/autotests/CMakeLists.txt f126859 > tier4/frameworkintegration/src/platformtheme/CMakeLists.txt 5d95c8a > tier4/frameworkintegration/src/platformtheme/kdeplatformfontdialoghelper.h > PRE-CREATION > > tier4/frameworkintegration/src/platformtheme/kdeplatformfontdialoghelper.cpp > PRE-CREATION > tier4/frameworkintegration/src/platformtheme/kdeplatformtheme.h 69f1f44 > tier4/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp 010eed4 > > Diff: http://git.reviewboard.kde.org/r/114185/diff/ > > > Testing > ------- > > Works with the kfontrequestertest. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
