----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113910/#review44427 -----------------------------------------------------------
This review has been submitted with commit 5c4f98aff6bca46e1523a79d8d5148354e786f52 by Maarten De Meyer to branch frameworks. - Commit Hook On Nov. 25, 2013, 2:46 p.m., Maarten De Meyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113910/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2013, 2:46 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > This adds 2 examples to KArchive. > - helloworld: Very basic. Shows how to use with CMake and create archives. > - tarlocalfiles: Shows how to add local files to an archive. > > Looking for feedback on: > License? Currently BSD. > Code comments. More, less? > Readability? > > Other examples I'm working on: > helloworld with qmake > something with KCompressionDevice > perhaps a minimal ark like example > > > Diffs > ----- > > tier1/karchive/examples/helloworld/CMakeLists.txt PRE-CREATION > tier1/karchive/examples/helloworld/main.cpp PRE-CREATION > tier1/karchive/examples/tarlocalfiles/CMakeLists.txt PRE-CREATION > tier1/karchive/examples/tarlocalfiles/main.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/113910/diff/ > > > Testing > ------- > > Builds and runs without errors. > > > Thanks, > > Maarten De Meyer > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
