----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113670/ -----------------------------------------------------------
(Updated Nov. 10, 2013, 11:42 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description ------- Link kde4support privately to QtX11Extras, QtSvg and QtTest Otherwise every user of the target KF5::KDE4Support will also have Qt5::X11Extras Qt5::Svg Qt5::Test linked. This can cause linker errors like "ld: cannot find -lQt5::Test" REVIEW: 113670 Diffs ----- tier4/kde4support/src/CMakeLists.txt cbfac3e tier4/kde4support/src/kdeui/kxerrorhandler.h babf931 tier4/kde4support/src/kdeui/kxerrorhandler.cpp 3f4765d Diff: http://git.reviewboard.kde.org/r/113670/diff/ Testing ------- I previously got the following error compiling okteta, now it works: /usr/lib64/gcc/x86_64-suse-linux/4.7/../../../../x86_64-suse-linux/bin/ld: cannot find -lQt5::X11Extras /usr/lib64/gcc/x86_64-suse-linux/4.7/../../../../x86_64-suse-linux/bin/ld: cannot find -lQt5::Svg QtX11Info and QtSvg are not used in any installed headers, so IMO this should be fine qtest_kde.h does actually include QtTest headers, but only uses these types inside macros. And I guess any user of that header already also links to QtTest Thanks, Alexander Richardson
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
