----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113713/ -----------------------------------------------------------
(Updated Nov. 10, 2013, 5:23 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description ------- Just a couple of potential issues I noticed while investigating warnings... UDisks2 backend: Ignore propertiesChanged signal for generic interfaces We only store properties for UDisks2-specific interfaces, so we should only listen to updates to properties on those interfaces. Invalidate properties on D-Bus are *modified* ones, not removed ones The UDisks2 backend was claiming that properties that were invalidated were removed; this is not true. While they should be removed from the cache, the properties themselves have not gone away. Diffs ----- tier1/solid/src/solid/backends/udisks2/udisksdevicebackend.cpp 32aa53fe5a7d8b29cd644f46b3d906bd64d16b69 Diff: http://git.reviewboard.kde.org/r/113713/diff/ Testing ------- Builds, tests run. Thanks, Alex Merry
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
