----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113711/ -----------------------------------------------------------
(Updated Nov. 10, 2013, 5:23 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description ------- KPassivePopup had a bunch of odd public API that no-one was using because it's useless to outside classes (even subclasses, of which there appear to be none). This hides that away, and makes the protected stuff actually useful. There are still some issues with the "next to the taskbar" positioning (it puts it alongside the entry instead of on the opposite side the screen edge), but that's less urgent than the API change. Clean up API of KPassivePopup Firstly, allow subclasses to more easily override the location: * remove defaultArea from the public API, as it is useless to clients * replace it with a virtual protected method defaultLocation Secondly, move other methods that should be private to the Private class. Thirdly, remove the Custom entry from the PopupStyle enum as there is, in practice, no easy way for subclasses to implement another style; by the time they do, they may as well start from scratch. Diffs ----- tier2/knotifications/src/kpassivepopup.h 4eb6ffc7b076391d3f74ce902cc964371b1046c8 tier2/knotifications/src/kpassivepopup.cpp f17086d3185e207b874f4dcfecf1da8715a3fd77 Diff: http://git.reviewboard.kde.org/r/113711/diff/ Testing ------- Still builds, test app still puts the popups where expected. Thanks, Alex Merry
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
