----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113696/#review43332 -----------------------------------------------------------
Ship it! No change was needed in CMakeLists.txt, therefore it's correct (provided that "make install" still works) :) - David Faure On Nov. 6, 2013, 7:17 p.m., Jeremy Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113696/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2013, 7:17 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > Renamed knewstuff private headers to _p.h and adjusted #include's accordingly. > > > Diffs > ----- > > tier3/knewstuff/src/attica/atticaprovider.h > 38aacfa377c91c54951eec9923f9b1712a0f4e32 > tier3/knewstuff/src/attica/atticaprovider.cpp > b077b23a3decb644b6ab5d15dc1283dfcd0e05b2 > tier3/knewstuff/src/core/author.h > tier3/knewstuff/src/core/author.cpp > 12cde54d806fdf674fb413d59a586db831de082d > tier3/knewstuff/src/core/cache.h 03373377cb91df9d5448e6231b008bd7949a8364 > tier3/knewstuff/src/core/cache.cpp 66e3ed13c690437cbbb3a43a518e22b5d5240581 > tier3/knewstuff/src/core/engine.h 7f0bc3021ef21b1621bff51fcb76e0579452f6e7 > tier3/knewstuff/src/core/engine.cpp > 941b1d0753320f57641c868f94959d9bf93148f7 > tier3/knewstuff/src/core/entryinternal.h > 08f6dcf02e0a765a80a0df24375381e1d6fdf909 > tier3/knewstuff/src/core/entryinternal.cpp > 2eb592d771dbc3f5ec1e38b7c7d0231b49736543 > tier3/knewstuff/src/core/installation.h > aec5e71d449a3e13108e636553a721b56a1af08f > tier3/knewstuff/src/core/installation.cpp > 7ec710ac80ae2011e9d975aa5d00763b04b084bd > tier3/knewstuff/src/core/provider.h > 0e3f7bc6efd3d205442c70d79035984848a1b7c8 > tier3/knewstuff/src/core/provider.cpp > 294d8665971e8547abfccd47785f655a85d8796b > tier3/knewstuff/src/core/security.h > tier3/knewstuff/src/core/security.cpp > eec03c39d3f1b5296ddd81525f4868359b46497c > tier3/knewstuff/src/core/upload.h > tier3/knewstuff/src/core/upload.cpp > ef62cf10ad1d580df8b894ac70044ad9a286b827 > tier3/knewstuff/src/core/xmlloader.h > tier3/knewstuff/src/core/xmlloader.cpp > 65b6de95c4902adb1beb2761dec54d7526036b2b > tier3/knewstuff/src/downloadmanager.cpp > df06786b0cf136c2f7f52e85cbeb7a61835acad6 > tier3/knewstuff/src/downloadwidget.cpp > 1d56e1106fb3ce1aa3f4a7f3b07a68732101b3ce > tier3/knewstuff/src/downloadwidget.ui > 17f2944e81c0510eb7ae85128e79e815eab1bf54 > tier3/knewstuff/src/downloadwidget_p.h > 080e1779e0d2ed110da28cc087218262fad1f333 > tier3/knewstuff/src/entry_p.h 73c1ee8619b171f90706ba3ed323abbd00add455 > tier3/knewstuff/src/staticxml/staticxmlprovider.h > 52caed08f53d125928d12f329c96800530d9fcaa > tier3/knewstuff/src/staticxml/staticxmlprovider.cpp > e7dd0686f122c938cf87959478acc97a0a25723b > tier3/knewstuff/src/ui/entrydetailsdialog.h > 0add71dfecd4f0cb8653e9a90568bad5d9d2e008 > tier3/knewstuff/src/ui/entrydetailsdialog.cpp > 5a451086531c53af720a2874f5c3b5ed51d07423 > tier3/knewstuff/src/ui/imageloader.h > 5e87a7b7890b6678c4b94aacc1b2f84d001b7dd0 > tier3/knewstuff/src/ui/imageloader.cpp > 8e6ed061e421e985535228599ff9da17303bae46 > tier3/knewstuff/src/ui/imagepreviewwidget.h > tier3/knewstuff/src/ui/imagepreviewwidget.cpp > d9d20775a9686715176ead2f24f122d82b88987b > tier3/knewstuff/src/ui/itemsgridviewdelegate.h > a5d793d8c859c25639921cc9a05233cb9879377e > tier3/knewstuff/src/ui/itemsgridviewdelegate.cpp > 3970287927e8c17acc9347adbae4c342c78d389a > tier3/knewstuff/src/ui/itemsmodel.h > 7bc691483b3f0a27dc0d35a7fa6a4ad877294c1a > tier3/knewstuff/src/ui/itemsmodel.cpp > d972c53f2963dba4ed55bfb484005b77b056c323 > tier3/knewstuff/src/ui/itemsview.h > tier3/knewstuff/src/ui/itemsview.cpp > b200b651bf1c57b37c7d8cb8163246488e6b17fb > tier3/knewstuff/src/ui/itemsviewbasedelegate.h > bbb08dbc1755b9d9c5bde20c27e7bf368c149c29 > tier3/knewstuff/src/ui/itemsviewbasedelegate.cpp > 89e91f9563f95985759388dcfca76d480a9dedba > tier3/knewstuff/src/ui/itemsviewdelegate.h > 1df97a36fc72d9eb3b2d07c5edff0170db459ea5 > tier3/knewstuff/src/ui/itemsviewdelegate.cpp > 5289ee0093e7e4d02e6250bad8807f7c7e0d04c7 > tier3/knewstuff/src/ui/progressindicator.h > tier3/knewstuff/src/ui/progressindicator.cpp > ab06ff19c103c4d809d9ef4b14586bcd936e75c5 > tier3/knewstuff/src/upload/atticahelper.h > tier3/knewstuff/src/upload/atticahelper.cpp > c17b743c29943fbd25020dc9c8b7a0862cdc2458 > tier3/knewstuff/src/uploaddialog_p.h > 084d626c095465b5176aa928fed1d6d6342e6e2d > > Diff: http://git.reviewboard.kde.org/r/113696/diff/ > > > Testing > ------- > > It still builds. > > > Thanks, > > Jeremy Whiting > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
