> On Nov. 7, 2013, 12:50 p.m., Alex Merry wrote: > > tier3/kross/CMakeLists.txt, lines 29-31 > > <http://git.reviewboard.kde.org/r/113703/diff/1/?file=211380#file211380line29> > > > > These shouldn't be needed; we should fix how KIO is generating > > KIOConfig.cmake first (it's not listing its dependencies properly).
I think I fixed this yesterday in commit fd4771d7f11b847cc9ea9dbe1590f92893d16a12. Can you check you still need the find_package() calls? - Aurélien ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113703/#review43213 ----------------------------------------------------------- On Nov. 7, 2013, 12:23 p.m., Maarten De Meyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113703/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2013, 12:23 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > Make kross build standalone. > > > Diffs > ----- > > tier3/kross/src/modules/CMakeLists.txt > 198cb047131702fc60b046ec30c86e342d4a79fc > tier3/kross/CMakeLists.txt 440edf23308f4b6fa57e66d592a01ba6024ec22d > > Diff: http://git.reviewboard.kde.org/r/113703/diff/ > > > Testing > ------- > > Builds. > Not added to superbuild. > > > Thanks, > > Maarten De Meyer > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
