----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113589/#review42958 -----------------------------------------------------------
Ship it! Ship It! - Kevin Ottens On Nov. 3, 2013, 3:05 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113589/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2013, 3:05 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > Allow test-kconf_update to run before kconfig is installed > > While we can't reasonably expect "make test" to work before "make install" in > frameworks as a whole, as various tests depend on an installed kded for > example, it should be possible to run the tests of any individual framework > before that framework is itself installed. Tests should depend on the > current *build*, not the current installation. > > > Diffs > ----- > > tier1/kconfig/autotests/test_kconf_update.cpp > 5226c60b9b275a7faa599507d3238107c6361ba7 > tier1/kconfig/src/kconf_update/config-kconf.h.cmake > 27cdb98d7a85a70fd4299b095d4b9aa032cca126 > > Diff: http://git.reviewboard.kde.org/r/113589/diff/ > > > Testing > ------- > > "make test" in kconfig now succeeds before the frameworks are installed. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
