----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113536/ -----------------------------------------------------------
(Updated Nov. 2, 2013, 2:32 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description (updated) ------- A whole bunch of commits (listed below in reverse order, like git log). This is a preliminary to actually fixing up some of the plugins (like the EPS one). Also, I intend to run astyle on the directory, which is a horrible mess of different styles (even within the same file). But that's not included in this request, since it would make the diff fairly useless. Remove the unhelpful ChangeLog Improve README file Mostly remove the list of plugins, since that is the sort of information that will not be kept in sync. Remove uppercase keys from imageformat json files QImageReader/Writer lowercases image formats before searching for plugins, so uppercase keys are useless. Add desktop file for WBMP plugin This is provided by the qtimageformats module Do not install desktop files for imageformat plugins that are not built If missing libraries etc. mean we do not build a plugin, we should not install the desktop file for it. Add imageconverter app to test imageformat plugins It is a command-line utility that converts images from one format to another using QImageReader and QImageWriter. Move kguiaddons/src/plugins to kguiaddons/src/plugins/imageformats This allows the plugins to be used prior to installation (for example, by tests) by adding kguiaddons/src/plugins to Qt's search path. Diffs ----- tier1/kguiaddons/src/CMakeLists.txt e1b17f4fcbda1052e21303f61f313058a9190da5 tier1/kguiaddons/src/plugins/AUTHORS tier1/kguiaddons/src/plugins/CMakeLists.txt 0536abeddb40220626be2ca80bf68c4a5cf79351 tier1/kguiaddons/src/plugins/ChangeLog 3d9f6dc1463d628db8a9f8fadab18475cd15160e tier1/kguiaddons/src/plugins/Mainpage.dox tier1/kguiaddons/src/plugins/README 20f3ef0019b571947d390cecdadcdd4745e4fe28 tier1/kguiaddons/src/plugins/bmp.desktop tier1/kguiaddons/src/plugins/config-kimgio.h.cmake tier1/kguiaddons/src/plugins/dds.cpp tier1/kguiaddons/src/plugins/dds.desktop tier1/kguiaddons/src/plugins/dds.h tier1/kguiaddons/src/plugins/dds.json 38b3d9adb13ab959d53190b218f083ed02f7d0eb tier1/kguiaddons/src/plugins/eps.h tier1/kguiaddons/src/plugins/eps.cpp tier1/kguiaddons/src/plugins/eps.desktop tier1/kguiaddons/src/plugins/eps.json 225c2895efecec14f09e1d5bd1f115aaee6eb0a0 tier1/kguiaddons/src/plugins/exr.cpp tier1/kguiaddons/src/plugins/exr.desktop tier1/kguiaddons/src/plugins/exr.h tier1/kguiaddons/src/plugins/exr.json 26fb4978de5d69ea4a8c10939f1b7ac026a63d0f tier1/kguiaddons/src/plugins/g3r.h tier1/kguiaddons/src/plugins/g3r.cpp tier1/kguiaddons/src/plugins/gif.desktop tier1/kguiaddons/src/plugins/gimp.h tier1/kguiaddons/src/plugins/hdr.cpp tier1/kguiaddons/src/plugins/hdr.desktop tier1/kguiaddons/src/plugins/hdr.h tier1/kguiaddons/src/plugins/ico.desktop tier1/kguiaddons/src/plugins/imageformats/README PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/eps.json PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/rgb.json PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/wbmp.desktop PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/xview.json PRE-CREATION tier1/kguiaddons/src/plugins/jp2.h tier1/kguiaddons/src/plugins/jp2.cpp tier1/kguiaddons/src/plugins/jp2.desktop tier1/kguiaddons/src/plugins/jp2.json 5a92b36c58e3852f71493b6fe5db8b271b9f8513 tier1/kguiaddons/src/plugins/jpeg.desktop tier1/kguiaddons/src/plugins/mng.desktop tier1/kguiaddons/src/plugins/pbm.desktop tier1/kguiaddons/src/plugins/pcx.h tier1/kguiaddons/src/plugins/pcx.cpp tier1/kguiaddons/src/plugins/pcx.desktop tier1/kguiaddons/src/plugins/pcx.json b3a7fc97fcb43eda91e90278af71b71b5f1066a6 tier1/kguiaddons/src/plugins/pgm.desktop tier1/kguiaddons/src/plugins/pic.cpp tier1/kguiaddons/src/plugins/pic.desktop tier1/kguiaddons/src/plugins/pic.h tier1/kguiaddons/src/plugins/pic.json 68f6f37ad08f3a0b3199240f5a135806a2b8ef46 tier1/kguiaddons/src/plugins/pic_read.cpp tier1/kguiaddons/src/plugins/pic_rw.h tier1/kguiaddons/src/plugins/pic_write.cpp tier1/kguiaddons/src/plugins/png.desktop tier1/kguiaddons/src/plugins/pnm.desktop tier1/kguiaddons/src/plugins/ppm.desktop tier1/kguiaddons/src/plugins/psd.cpp tier1/kguiaddons/src/plugins/psd.desktop tier1/kguiaddons/src/plugins/psd.h tier1/kguiaddons/src/plugins/psd.json da33c688c0a2a75cdbe24637ca8fd4ae1ffe807f tier1/kguiaddons/src/plugins/qimageio_plugin.desktop tier1/kguiaddons/src/plugins/ras.cpp tier1/kguiaddons/src/plugins/ras.desktop tier1/kguiaddons/src/plugins/ras.h tier1/kguiaddons/src/plugins/ras.json 7ba02f4b8ad446cedc730d2a721c042a835b864d tier1/kguiaddons/src/plugins/rgb.cpp tier1/kguiaddons/src/plugins/rgb.desktop tier1/kguiaddons/src/plugins/rgb.h tier1/kguiaddons/src/plugins/rgb.json 876ce9c6b56389599ed94d08bc4d130d208cdfd5 tier1/kguiaddons/src/plugins/svg+xml-compressed.desktop tier1/kguiaddons/src/plugins/svg+xml.desktop tier1/kguiaddons/src/plugins/tga.cpp tier1/kguiaddons/src/plugins/tga.desktop tier1/kguiaddons/src/plugins/tga.h tier1/kguiaddons/src/plugins/tga.json 984d56e0b9508cb0e8383459a53060999637ffd2 tier1/kguiaddons/src/plugins/tiff.desktop tier1/kguiaddons/src/plugins/xbm.desktop tier1/kguiaddons/src/plugins/xcf.h tier1/kguiaddons/src/plugins/xcf.cpp tier1/kguiaddons/src/plugins/xcf.desktop tier1/kguiaddons/src/plugins/xcf.json da38a243cdf66c524e357fdbc19aafd0caecf764 tier1/kguiaddons/src/plugins/xpm.desktop tier1/kguiaddons/src/plugins/xv.desktop tier1/kguiaddons/src/plugins/xview.h tier1/kguiaddons/src/plugins/xview.cpp tier1/kguiaddons/src/plugins/xview.json 4765c68cc81ae6434936f4e280e1d652d9971de1 tier1/kguiaddons/tests/CMakeLists.txt 754b460e253c8856686ae442e4587c2ee57bb714 tier1/kguiaddons/tests/imageconverter.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113536/diff/ Testing ------- The new imageconverter test utility works (and uses the locally-built plugins before any installed ones). Thanks, Alex Merry
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
