----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113510/#review42758 -----------------------------------------------------------
Missing #ifndef KDE_NO_DEPRECATED around all the deprecated methods. kio/kio/kimageio.h <http://git.reviewboard.kde.org/r/113510/#comment30913> That's not really the same (this method returned PNG for image/png, right?) But I guess the point is that we don't need "PNG" when we have a mimetype name in the first place... kio/kio/kimageio.h <http://git.reviewboard.kde.org/r/113510/#comment30914> or QImageWriter::supportedImageFormats(), when mode=Writing, right? kio/kio/kimageio.h <http://git.reviewboard.kde.org/r/113510/#comment30915> same here, Reader or Writer, depending on what "mode" was. - David Faure On Oct. 30, 2013, 4:49 p.m., Jeremy Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113510/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2013, 4:49 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > KImageIO functions can be deprecated in favor of QImageReader and > QImageWriter functionality. > > > Diffs > ----- > > kio/kio/kimageio.h cecadf1 > > Diff: http://git.reviewboard.kde.org/r/113510/diff/ > > > Testing > ------- > > it still builds. > > > Thanks, > > Jeremy Whiting > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
