----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113503/#review42744 -----------------------------------------------------------
tier2/kjobwidgets/CMakeLists.txt <http://git.reviewboard.kde.org/r/113503/#comment30900> You don't need COMPONENTS here. I'm not sure about whether it's needed in the next line. tier2/kjobwidgets/CMakeLists.txt <http://git.reviewboard.kde.org/r/113503/#comment30901> You probably want if (Qt5DBus_FOUND) ? I think that the target is only created if it is found, but I can't be sure. A Config file can set its _FOUND variable to false if a necessary condition is not met (eg a file missing which should be packaged like a macros file - See the Qt config files for more.) tier2/kjobwidgets/src/CMakeLists.txt <http://git.reviewboard.kde.org/r/113503/#comment30902> Ditto. Indentation. tier2/kjobwidgets/src/CMakeLists.txt <http://git.reviewboard.kde.org/r/113503/#comment30903> Use PRIVATE, not LINK_PRIVATE (new in 2.8.12). Indentation and extra newline. tier2/kjobwidgets/src/CMakeLists.txt <http://git.reviewboard.kde.org/r/113503/#comment30904> Indent. - Stephen Kelly On Oct. 30, 2013, 10:08 a.m., Sune Vuorela wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113503/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2013, 10:08 a.m.) > > > Review request for KDE Frameworks, kdelibs and Stephen Kelly. > > > Repository: kdelibs > > > Description > ------- > > Make dbus dependency optional in JobWidgets > > Many don't have dbus available on all platforms, especially windows, but > JobWidgets is very much useful without it. > > > Diffs > ----- > > tier2/kjobwidgets/CMakeLists.txt ca53024 > tier2/kjobwidgets/src/CMakeLists.txt 0a575a6 > tier2/kjobwidgets/src/config-kjobwidgets.h.cmake 35b64a2 > tier2/kjobwidgets/tests/kjobtrackerstest.cpp 7a61407 > > Diff: http://git.reviewboard.kde.org/r/113503/diff/ > > > Testing > ------- > > build tested on windows without dbus. not yet tested on other platforms > > > Thanks, > > Sune Vuorela > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
