----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113511/#review42737 -----------------------------------------------------------
Ship it! staging/kio/src/core/CMakeLists.txt <http://git.reviewboard.kde.org/r/113511/#comment30898> you can remove the "temporary" comment too, then (but leave "used by ksslsettings") staging/kio/src/core/kssl/ksslsettings.cpp <http://git.reviewboard.kde.org/r/113511/#comment30899> strange indentation, are these tons of spaces, or a tab? (Hmm OK the rest of the file is even worse in terms of indentation...) - David Faure On Oct. 30, 2013, 5:44 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113511/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2013, 5:44 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > Install KSslSettings header > > Make ksslsettings use a d pointer > > > Diffs > ----- > > staging/kio/src/core/CMakeLists.txt 0664382 > staging/kio/src/core/kssl/ksslsettings.h a400f09 > staging/kio/src/core/kssl/ksslsettings.cpp 8fe882c > > Diff: http://git.reviewboard.kde.org/r/113511/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
