----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113424/#review42320 -----------------------------------------------------------
Ship it! whoami is part of coreutils, so should be available everywhere. The only possible issue I see is that we've gone from a test that doesn't depend on PATH to one that does. This isn't necessarily a problem, but it will test slightly different code paths. - Alex Merry On Oct. 24, 2013, 3:59 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113424/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2013, 3:59 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > Use "whoami" as the command in KDesktopFileTest::testSuccessfulTryExec() > > Unlike "/bin/ls" this also works on Windows > > > Diffs > ----- > > tier1/kconfig/autotests/kdesktopfiletest.cpp > 8f2ed2047e39f4f6b5d24a620474c3894f7986cc > > Diff: http://git.reviewboard.kde.org/r/113424/diff/ > > > Testing > ------- > > Test passes on both linux and windows > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
