----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112755/ -----------------------------------------------------------
(Updated Oct. 24, 2013, 12:22 p.m.) Review request for KDE Frameworks. Changes ------- * added a small test app which is able to render the icon of a passed in window id into a QLabel * added a byte order check, if not LSB no image conversion is done * added better depth and visual conversion. Only a small subset is checked with inspiration from kde-workspace/ksmserver/logouteffect.cpp For testing I used iceweasel and xclock. Both work fine. Repository: kdelibs Description ------- Implements the createPixmapFromHandle by getting the image for the pixmaps and using it as either the Pixmap or the bitmap mask. Diffs (updated) ----- tier1/kwindowsystem/src/kxutils.cpp 33bd678 tier1/kwindowsystem/src/kxutils_p.h 84d639b tier1/kwindowsystem/tests/CMakeLists.txt 5cf5868 tier1/kwindowsystem/tests/createpixmapfromhandletest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112755/diff/ Testing ------- Adjusted KWin to take this codepath and say thanks to Iceweasel for having a mask Thanks, Martin Gräßlin
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
