----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113301/#review41858 -----------------------------------------------------------
I find this a better solution. So if I compare my review with this one, I would vote for this one. But I do not know why it was in a private header in the first place. - Martin Gräßlin On Oct. 17, 2013, 7:59 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113301/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2013, 7:59 a.m.) > > > Review request for KDE Frameworks and Martin Gräßlin. > > > Repository: kdelibs > > > Description > ------- > > Move KGlobalShortcutInfo DBus serialisation to a public header > > ----- > > See https://git.reviewboard.kde.org/r/113267/ > > Clients in kde-workspace are currently trying to import a private header > which completely defeats the point of something being private. > > > Diffs > ----- > > tier3/xmlgui/src/kglobalshortcutinfo.h d1ccd56 > tier3/xmlgui/src/kglobalshortcutinfo_p.h 57f2bd5 > > Diff: http://git.reviewboard.kde.org/r/113301/diff/ > > > Testing > ------- > > Built kde-workspace (with a minor change there) > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
