----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/#review40866 -----------------------------------------------------------
> Maybe KF5_SELF_VERSION could be shortened to KF5_VERSION? Yes, that might be better. The patch looks good to me now. The above naming issue and the other re-ordering issue are up to your preferences. This also marks a change in convention (removing a lot of stuff), so get Kevin to approve it for you. - Stephen Kelly On Sept. 26, 2013, 1:13 p.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112928/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2013, 1:13 p.m.) > > > Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly. > > > Description > ------- > > This patch adds a template/ dir which contains example CMakeLists.txt and > FooBarConfig.cmake.in files, based on what exists in current frameworks. > > > Diffs > ----- > > template/CMakeLists.txt PRE-CREATION > template/FooBarConfig.cmake.in PRE-CREATION > template/setup.sh PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/112928/diff/ > > > Testing > ------- > > > Thanks, > > Aurélien Gâteau > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
