-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112839/#review40382
-----------------------------------------------------------

Ship it!


Ship It!

- Stephen Kelly


On Sept. 20, 2013, 1:41 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112839/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2013, 1:41 p.m.)
> 
> 
> Review request for Build System, KDE Frameworks, Alexander Neundorf, and 
> Stephen Kelly.
> 
> 
> Description
> -------
> 
> One of the most important things kde4_add_plugin was doing was stripping 
> MODULE targets from its prefix. This change makes it so those targets won't 
> get the prefix by default.
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDECMakeSettings.cmake 704e4ce 
> 
> Diff: http://git.reviewboard.kde.org/r/112839/diff/
> 
> 
> Testing
> -------
> 
> Builds.
> Changed locally some kde4_add_plugin to add_library( MODULE ) and they didn't 
> have a prefix.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Reply via email to