> On Sept. 18, 2013, 5:23 p.m., Mark Gaiser wrote: > > Posting the same here as i just said in your other review request. (I > > didn't see this one) > > Idea: restore naturalCompare as it was and add a "collatorNaturalCompare" > > that is taking the QCollator route. That way it's easily testable as well. > > > > I think we can all agree on that, right?
** posting again as well... ** I don't think creating such function would be a good thing because it means using QCollator the wrong way. I much rather prefer working on tools to properly use QCollator, for example by making it possible to sort things with the sort key instead of QCollator::compare which will be the place where we can actually test performance. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/#review40289 ----------------------------------------------------------- On Sept. 18, 2013, 4:55 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112797/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2013, 4:55 p.m.) > > > Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser. > > > Description > ------- > > Apparently there's people who still want to have it. Leave it in KCoreAddons > for the moment, until we decide that it can be replaced for good by QCollator. > > > Diffs > ----- > > tier1/kcoreaddons/autotests/kstringhandlertest.cpp 93da351 > tier1/kcoreaddons/src/lib/text/kstringhandler.h 442b97a > tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 > > Diff: http://git.reviewboard.kde.org/r/112797/diff/ > > > Testing > ------- > > Builds, tests pass. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
