On Monday 16 September 2013 16:51:45 Aurélien Gâteau wrote: > On Monday 16 September 2013 15:07:37 Martin Graesslin wrote: > > Hi, > > > > KWindowSystems is a framework which looks to me like a KX11Extras > > framework. Most of the things inside this framework are X11 specific. > > Some API even has XLib/XCB specific data types as arguments or return > > values (e.g. netwm.h). The only class which has a non-X11 implementation > > is > > KWindowSystem and KWindowInfo, but also those are highly X11 inspired. > > > > My suggestion would be to create a new tier1 framework KX11Extras which > > contains: > > * fixx11h.h > > * KManagerSelection > > * KStartupInfo > > * KXMessages > > * NETwm > > > > The KWindowSystems framework would need to become a tier2 framework and as > > it needs to depend on NETwm (X11 implementation uses it and the defines > > are > > used). It would contain: > > * KKeyServer > > * KWindowEffects (this could also stay in X11Extras) > > * KWindowInfo > > * KWindowSystem > > > > Opinions? > > If KWindowSystems becomes tier2 then KInterProcessWindowing would become > tier3, this is another good reason to move the code from > KInterProcessWindowing to other frameworks and get rid of it, therefore I > approve :) > > I assume the KUserTimestamp namespace could go in KX11Extras? yes that's another case for "makes only sense on X11" and would simplify the code as we could drop all the ifdefs.
Cheers Martin
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
