----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112702/ -----------------------------------------------------------
Review request for KDE Frameworks and kdelibs. Description ------- This patch actually does two things: 1. A small indentation fix that this diff doesn't show properly (i can commit that as a separate commit if that's preferred) 2. A cleanup in how a listDir is handled. It used to be required to send a listEntry(UDSEntry, true) to indicate that the listing is completed. Then the UDSEntry was skipped. It seemed vague to me so i deprecated that function and added a new listEntry that doesn't take a bool. Now you just have to call finished() when done listing. finished() was already required otherwise KIO would blame you with warnings :) Diffs ----- kioslave/file/file_unix.cpp 48bd0ba staging/kio/src/core/slavebase.h b46631e staging/kio/src/core/slavebase.cpp 2e46985 Diff: http://git.reviewboard.kde.org/r/112702/diff/ Testing ------- Thanks, Mark Gaiser
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
